-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed eav_config_entity throwing error message on removed entity model #3338
Fixed eav_config_entity throwing error message on removed entity model #3338
Conversation
Please note I only "fixed" the issue caused by eager loading of entity types, eager loading of attributes with non-existent models always caused issues in the past as well (eg. deleting a module with a class that was used as custom attribute source_model or frontend/backend type model always caused issues in the past, removing those checks would be quite extensive and I at least prefer to be warned "early" of such issues). |
Accidentally deleted all my VBox images and had no time to recreate. Can't test it during next days. |
@sven - I will make time these days to simulate your case. DDEV in my case requests only a couple of minutes to run an OM instance from scratch. I will install an extension then delete it from the file system. I should get your error, then I checkout this PR to see what happens. Do I need to take other steps to reproduce the issue? |
@addison74 thanks. I know it takes only minutes to setup OM, but I've to do some more things. Need a new HDD, update my whole system from Win7 (do not laugh 😂), but the most important ... my beloved dog is 9y now and I just want to spend as much time as possible with her. To reproduce ... install the extension you sent me and remove all files. No further steps. |
It's much easier to simple insert a new entry into the eav_entity_type table with a non-existent model class. |
I confirm this PR solves the issue reported here #3175. |
A fix for #3175 ensuring that the eav entity type class is present before proceeding to load it to gracefully handle removed modules and/or leftover data.
Purposely throws exception in developer mode to highlight the leftover data and only logs a statement once every time data is loaded from the database.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)